Skip to content

feat: adjusted UI api auth#108

Merged
Mesh-ach merged 8 commits into
stagingfrom
develop
Jun 9, 2025
Merged

feat: adjusted UI api auth#108
Mesh-ach merged 8 commits into
stagingfrom
develop

Conversation

@Mesh-ach
Copy link
Copy Markdown
Contributor

@Mesh-ach Mesh-ach commented Jun 9, 2025 •
edited
Loading

changes

  • Replaced OAuth2PasswordBearer with HTTPBearer for JWT-based auth
  • Renamed auth scheme to clarify usage (Bearer token (from API key login)) in FastAPI docs
  • Removed legacy username/password flow references

context

  • FastAPI UI incorrectly showed OAuth2 login form due to OAuth2PasswordBearer, which we don’t use
  • Backend relies solely on API keys to issue JWTs; username/password flow is deprecated

questions

No question at this time

@Mesh-ach Mesh-ach requested a review from emmaeturner June 9, 2025 15:58
emmaeturner
emmaeturner requested changes Jun 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@emmaeturner emmaeturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR correctly removes OAuth2PasswordBearer and replaces it with HTTPBearer to align FastAPI's UI and backend behavior with the actual JWT-based, API-key issued authentication. Swagger docs now behave as expected. I’ve verified no username/password flows remain. Just one small suggestion: either fully remove the commented OAuth2 code or leave a TODO note for clarity. Once the type-check failure is resolved, this is good to go!

@Mesh-ach
Copy link
Copy Markdown
Contributor Author

Mesh-ach commented Jun 9, 2025

This PR correctly removes OAuth2PasswordBearer and replaces it with HTTPBearer to align FastAPI's UI and backend behavior with the actual JWT-based, API-key issued authentication. Swagger docs now behave as expected. I’ve verified no username/password flows remain. Just one small suggestion: either fully remove the commented OAuth2 code or leave a TODO note for clarity. Once the type-check failure is resolved, this is good to go!

Got it, will remove the comments now.

@Mesh-ach Mesh-ach merged commit e32ec02 into staging Jun 9, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmaeturner emmaeturner emmaeturner requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mesh-ach @emmaeturner